Skip to content

Make the Read Receipts dialog scrollable again#631

Merged
nushea merged 8 commits intoSableClient:devfrom
Septicity:fix/read-receipt-scrolling
May 4, 2026
Merged

Make the Read Receipts dialog scrollable again#631
nushea merged 8 commits intoSableClient:devfrom
Septicity:fix/read-receipt-scrolling

Conversation

@Septicity
Copy link
Copy Markdown
Contributor

Description

At some point between commits 43cb531 and f4cc4d5, in the process of switching various UI elements into unified modals, the read receipts modal (specifically the one that opens from an individual message's context menu) lost its ability to be scrolled through.

In this patch, I've reverted that specific component to its old form, both to immediately return the functionality and to provide a useful reference state for the process of creating a more polished fix.

I recommend directly patching this pull request to properly unify the modals first, but it should be functional enough on its own to be implemented as an immediate fix if you prefer.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@Septicity Septicity requested review from 7w1 and hazre as code owners April 2, 2026 05:40
@Septicity
Copy link
Copy Markdown
Contributor Author

Looks like some jank from merging the old code made it through, as well as some linter troubles...

@nushea
Copy link
Copy Markdown
Contributor

nushea commented Apr 6, 2026

Looks like some jank from merging the old code made it through, as well as some linter troubles...

honestly needing ESLint and prettier were good reasons to me to move to vs codium just for this project, because dealing with these manually is just a pointless headache

@Septicity
Copy link
Copy Markdown
Contributor Author

Septicity commented Apr 6, 2026

I have VSCode and those formatting extensions already! It added the parts that are being flagged... I've mainly not gotten around to working this out because this is supposed to be the "jank" fix before it's properly integrated with the new modal setup.

@nushea nushea force-pushed the fix/read-receipt-scrolling branch from f8d3a17 to 3940105 Compare May 1, 2026 01:51
@nushea nushea marked this pull request as draft May 1, 2026 01:54
@nushea nushea force-pushed the fix/read-receipt-scrolling branch from 3940105 to ec2f3bc Compare May 1, 2026 01:58
@nushea nushea marked this pull request as ready for review May 1, 2026 02:15
@nushea nushea enabled auto-merge May 1, 2026 02:19
@nushea nushea added this pull request to the merge queue May 4, 2026
Merged via the queue into SableClient:dev with commit f44835d May 4, 2026
12 checks passed
ProfessorVarox pushed a commit to ProfessorVarox/sable that referenced this pull request May 5, 2026
> [!IMPORTANT]
> Merging this PR will create a new release.

## Features

* Add background styling to user profile cards
([SableClient#712](SableClient#712) by @nushea)
* Add preventing url preview cards by surrounding a link in
anglebrackets like <https://app.sable.moe>
([SableClient#717](SableClient#717) by @nushea)
* Reorganize Embed settings and reintroduce multiple embeds
([SableClient#667](SableClient#667) by @nushea)
* Change Misc. data styling in users profile pages
([SableClient#663](SableClient#663) by @nushea)
* add initial support for sending discoverable emojis and sticker
([SableClient#730](SableClient#730) by @dozro)

### Themes and tweaks from the catalog
([SableClient#633](SableClient#633) by @7w1)

Themes are pulled from [a repo](https://github.com/SableClient/themes)
now, so you get the full power of CSS instead of a palette. Tweaks are
new: CSS overlays that sit on top of whatever theme you are using.

You'll be prompted to migrate to the new system whenever you update, if
you choose not to, you'll be limited to the basic dark/light themes. A
few additional themes have been added (Rose Pine variantes, Catpuccin)
along with some basic tweaks (circular avatars, monochrome avatars, and
square stuff).

You can share themes and tweaks. For themes uploaded online, simply hit
the copy button in settings and paste the link in chat. If the setting
is enabled, a preview will be generated. Third party themes (as defined
by the config.json) have prominent warning banners and fetching is
disabled by default.

You can also export and share theme files directly, although no previews
are generated for these.

If you're intrested in getting a theme or tweak added to the official
catalog, contribute to the themes repo linked above! We're eager to add
more!

### Markdown parser and render updates
([SableClient#727](SableClient#727) by @7w1)

Migrated markdown parsing and rendering to use marked, which should fix
most (all?) markdown issues involving lists/nested structures,
inconsistent/inaccurate code blocks, escape sequences, and all the other
bugs with literally everything.

Added math rendering support via marked and KaTeX, uses standard `$$`
and `$` delimiters. Only renders a subset of latex tags that will likely
need to be expanded so feel free to make issues if needed.

Also adds support for sending markdown tables (although they're rendered
rather plainly at the moment), sending valid html directly (such as for
colored text), and properly escaping anything with backslashes.

Fixes link previews appearing in code blocks, fixes pmp new line
behavior, fixes links not opening in new tabs, and fixes editing
arbitrary html messages, probably.

Finally, the old WYSIWYG editor has been completely removed.

## Fixes

* Fix spam-clicking abbreviations crashing sable
([SableClient#665](SableClient#665) by @nushea)
* Add cache-control headers in Caddyfile for assets, service worker, and
index.html ([SableClient#609](SableClient#609) by
@Just-Insane)
* Fix the first pin event in a room looking empty
([SableClient#685](SableClient#685) by @nushea)
* Fix read receipt scrolling not working
([SableClient#631](SableClient#631) by @Septicity)
* Fix status sometimes sticking in member tile
([SableClient#664](SableClient#664) by @nushea)
* Fix apng files not animating.
([SableClient#737](SableClient#737) by @7w1)
* Some fixes to sync requests being spammed on loading screen and for
multi-account background syncing, it should also load faster now!
([SableClient#736](SableClient#736) by @7w1)
* Fix other dmed party not being added as a founder by default when
creating a dm. ([SableClient#737](SableClient#737) by
@7w1)
* Update verbiage in the credits
([SableClient#728](SableClient#728) by @nushea)
* spoilered text now gets replaced with `[Spoiler]` in the plain text
fallback, as per MSC4454
([SableClient#715](SableClient#715) by @dozro)
* Hide copied settings links on dynamic rows
([SableClient#695](SableClient#695) by @hazre)
* Fix button hover background smearing in virtual list rows by
suppressing transform on hover
([SableClient#614](SableClient#614) by @Just-Insane)
* Fix Workbox precaching by removing injectionPoint override that was
silently disabling all precache entries
([SableClient#611](SableClient#611) by @Just-Insane)

### Change how settings links are shared
([SableClient#695](SableClient#695) by @hazre)

Settings links copied from Sable now stay on the current client URL and
include a small Sable marker in the link. That lets Sable recognize
settings links copied from other Sable instances without treating
unrelated third-party `/settings/...` links as Sable settings links.

When you send a bare settings link in the composer, Sable now rewrites
it into a labeled link so it looks better on non-Sable clients too. For
example: `[Settings > Account > Display
Name](https://client.example/settings/account?focus=display-name&moe.sable.client.action=settings)`.

Invalid or malformed settings-looking links now stay normal links
instead of being shown as settings chips.

If you previously set `settingsLinkBaseUrl` in `config.json`, remove it.
Sable now derives settings links from the runtime app URL, and the old
config key is no longer used.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants